hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
117 stars 6 forks source link

Allow users to show images in alternate ways #12

Closed hungsu closed 2 years ago

hungsu commented 2 years ago

Mentioned in #9

I'll have to consider which image positioning options users might want, and how to implement them. This may be better suited for a CSS snippet.

hungsu commented 2 years ago

Marty on the Obsidian Forums requests Image Grid, like the ITS theme

Looks easy to implement! Although I do wish Obsidian had a Snippet store so that we don't have to keep using Themes to do this.

olrenso commented 2 years ago

+1 for this. Also, image captions would be nice, like in the ITS and the Discordian themes.

DubiousCactus commented 2 years ago

Is there any news on this? This theme is one of the best I've found so far!! But the absence of image captions makes me reluctant to use it for my Publish blog...

hungsu commented 2 years ago

Hi @DubiousCactus ! I had forgotten about this issue, but curiously in the last 24 hours there seems to be a spike of interest in Typomagical, so I'm looking to devote some time to it. I wouldn't be looking at this today, but likely this weekend.

I don't have any experience with Obsidian Publish. To speed things along, by any chance have you come across another theme that has image captions that you like?

DubiousCactus commented 2 years ago

Hi @hungsu, thanks for getting back to me so quickly! I myself tried to add the feature by stealing code from Shimmering Focus which adds nice image borders, centre-aligned captions for images and embeds, and zoomable images. I managed to get the zoom working but not the image captions. It's been so long since I've last looked at CSS that I don't really know what I'm doing, but I might try more this week and maybe submit a pull request if I get it to work.

hungsu commented 2 years ago

Hi @DubiousCactus ,

I had a look at ShimmeringFocus today and captions do not seem to work for me, and I'm using Obsidian 1.0.2. I also tried loading Shimmering Focus's CSS into someone else's Publish site and also did not see image captions, and I'm not sure it could work with pure CSS as the HTML is only a single <img> tag without a figcaption element. You sound like you had captions working at some point on your blog. Would you be able to link to your blog with a theme that has the captions working?

DubiousCactus commented 2 years ago

Hi @hungsu,

That's strange, I have the latest version of the theme and it works. You can see it on my blog.

hungsu commented 2 years ago

Thanks very much for that @DubiousCactus , I can see how it works. I should be able to patch this tonight

hungsu commented 2 years ago

image

hungsu commented 2 years ago

Hey @DubiousCactus , please update the theme and let me know if image captions work for you

DubiousCactus commented 2 years ago

That works perfectly, thanks so much!