search

hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
115 stars 5 forks source link

Added basic Live Preview support #21

Closed olrenso closed 2 years ago

olrenso commented 2 years ago

The last Live Preview builds seem to be more stable and reliable. Given that I'm currently testing it, I though to fix some basic styling also to the Live Preview mode.

I mainly fixed the heading size, padding and tried to mimic the look of the lists.

Unfortunately, I had to use some '!important' to override some hardcoded padding and margin.

hungsu commented 2 years ago

Hi @Lorenzoss ! Thank you so much for this I'm amazed! You were so thoughtful with everything!

I've updated this PR to change the target branch, so that I can try to remove the !important. If I can't I'll just merge it into main. Thank you so much again! ❤️

hungsu commented 2 years ago

Hi @Lorenzoss ! I'd love to keep working on WYSIWYG, but I suspect getting it to work will require a different approach. It is a little annoying how much we have to fight the weird styles that come with this editor, and also annoying that we have to keep rethinking our work if the editor gets updated. I'd like to think about the problem some more and would love to keep working with you on solutions! For the time being though, I've removed the lovely work you've done while I think things through

olrenso commented 2 years ago

Hi @hungsu! I fully agree, it's quite exasperating how the new Code Mirror 6 broke almost all the plugins and how the live preview mess with the themes. Even more now that with the last build they set it to be the default one, instead of cm5. Even if I don't plan to extensively use the live preview mode I'd love to help you to improve this awesome theme.