search

hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
114 stars 5 forks source link

Feature request: Background color #33

Open Calorion opened 2 years ago

Calorion commented 2 years ago

I would like to be able to specify a background color for the body field.

hungsu commented 2 years ago

Hi @Calorion ! Thankfully this is easy. Do you mind updating your version of Typomagical, and trying the setting in Typomagical Color Settings ?

Calorion commented 2 years ago
  1. The System panes become transparent when I turn "allow background color override" on if the color is set to default.
  2. I only want the color to apply to the text body, not the System panes.
  3. Unfortunately, I think you're going to need two different options: A Light Mode and a Dark Mode color.
  4. I don't suppose you can invoke the System color picker? iOS, for instance, has a very nice built-in one.

Other than that, it works!

hungsu commented 2 years ago

Hi @Calorion ,

Regarding transparent system panes and colour applying to system panes, what version of Obsidian and what operating system did you see this problem on? And by chance are you using the Translucent window setting in Appearance ? I'm not observing this problem on my Windows or Mac machines, on 0.13.26

As for system color picker, that's out of my hands as it's controlled by the Style Settings Plugin. There is discussion about a better picker over here: https://github.com/mgmeyers/obsidian-style-settings/issues/50

Calorion commented 2 years ago

Regarding transparent system panes and colour applying to system panes, what version of Obsidian and what operating system did you see this problem on?

iPadOS 15.2.1, Obsidian 1.1.0.

And by chance are you using the Translucent window setting in Appearance ? I'm not observing this problem on my Windows or Mac machines, on 0.13.26

That setting has no effect.

Smitty010 commented 1 year ago

I observed the problem on Windows (Obsidian 1.1.16). The settings dialog became unreadable as soon as I clicked on "Allow Background color override" (it was the only setting I changed in the Style Settings). I had to find the typomagical settings in the Style plugin data.json and delete the line to get my Obsidian usable again.

hungsu commented 1 year ago

I see the problem. Putting together a fix

hungsu commented 1 year ago

This should be fixed now in Typomagical 1.5.2