search

hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
114 stars 5 forks source link

Respect user's font choice #41

Open hungsu opened 2 years ago

hungsu commented 2 years ago

In v0.14.3, Obsidian added a new dropdown for users to select their own font. I'd like to investigate how I can work with this and Typomagical's font settings.

hungsu commented 2 years ago

https://discord.com/channels/686053708261228577/716028884885307432/958106643428675634

visualcurrent commented 1 year ago

This is still aggravating me so much. The font it's forcing isn't even in my system. There's just no settings that will fix it. Furthermore it forces link fonts to be a different size and there's no way to fix that either.

hungsu commented 1 year ago

@visualcurrent sorry to hear! 😦 let me revisit this

hungsu commented 1 year ago

@visualcurrent , could you update Typomagical to 1.7.2 and see if this is resolved for you?

visualcurrent commented 1 year ago

@hungsu , no, 1.7.2 doesn't seem to resolve any of this.

By the way, all below sounds like a lot of complaining so I just want to balance that by saying that overall, your theme is magical and so pleasant to work in. Your cohesive styling is very much appreciated.

What I see in Style Settings (for 1.7.2 and previous) are hardwired font options that are obscure (in that I've never heard of most of them) that can't be changed, they aren't installed on my computer system, and they have no relation to the fonts chosen in the main settings for Obsidian.

Maybe it's programmatically impossible for the theme to see the font collections listed in the Obsidian Settings > Appearance section. But the behavior I would expect to see in your Style settings is that the Font pull down menus would simply offer the culmination of fonts listed in the Obsidian Settings.

Furthermore, internal link fonts are different than body links and external link fonts are both different and resolved as a significantly smaller size. I'm sorry, I don't know if these settings are controlled by your theme or by Obsidian settings. But these size and font discrepancies just wreck table readability in edit mode. Something I work with a lot and tables are a real challenge to edit when columns refuse to line up due to all these font irregularities.

hungsu commented 1 year ago

Thank you, I was beginning to wonder why you were commenting as it didn't seem like you used or liked my theme at all

The hardwired font options in style settings are distinct from the options in Appearance, as Style Settings has no knowledge of what is there. The hardwired options are provided by a mix of Google Fonts and Bunny Fonts. As you suspect, there is no way for me to combine the lists.

Internal links being different size from other links is a bug - they are the same size on my system, and that's expected as I didn't write any code to make one different from the other. This is a separate issue from "Respect user's font choice" but we'll continue here for now since you're already here.

hungsu commented 1 year ago

image

Do let me know if you still see the issue. I would expect thing to look like the above screenshot.