search

hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
115 stars 5 forks source link

Typomagical doesn't respect accent color everywhere in dark mode #48

Closed joelatschool closed 1 year ago

joelatschool commented 1 year ago

While in light mode, the accent color is used everywhere in Typomagical (color of links, color of gradient on titles if enabled, UI, etc), in dark mode it seems to only use the accent color for UI, and links and gradients stay purple no matter what.

hungsu commented 1 year ago

Hi there, I'll see what I can do!

awsharif commented 1 year ago

I just noticed this - would be great to have consistency with accents in dark mode. Ps. I love the theme!

TheFermi0n commented 1 year ago

I have recently moved from using raw latex files for managing notes to Obsidian. For someone who is obsessed with the serif font Typomagical has amazed me because of its cool look and typography. I had this issue as well. So, tried to solve it a little bit.

Add this code in your css snippet. It should solve the links not matching accent color problem. And for the gradient in the heading, I don't really like it. So, I didn't even bother to check it. 

/* not hovered */
a,
.cm-s-obsidian span.cm-link,
.external-link,
.cm-s-obsidian span.cm-hmd-internal-link,
:not(a, .cm-hmd-internal-link, .cm-link-alias) > .pandoc-citation.is-resolved {
    color: var(--text-accent);
}
/* hovered */
a:hover,
.external-link:hover,
:not(a, .cm-hmd-internal-link, .cm-link-alias) > .pandoc-citation.is-resolved:hover,
.cm-s-obsidian span.cm-hmd-internal-link:hover,
.cm-s-obsidian span.cm-link:hover {
    color: var(--text-accent-hover);
}
hungsu commented 1 year ago

Hi everyone - this should be fixed with the newest version of Typomagical, 1.7.3. If it isn't, please comment and I'll take another look