hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
114 stars 5 forks source link

Bulletpointing broken in reader view #52

Closed SerosKanjus closed 1 year ago

SerosKanjus commented 1 year ago

There are a significant issues with displaying bullet points in reader view, at least in ficus ruby dark mode.

For a start, in editor view, a bulletpoint, followed by a new line with unbulletpointed text displays as you'd expect it to:

image

in reader view, however, all the text gets pulled into one block, ruining the point of bullet-pointing and readability in general.

image

As you'll notice, for some reason there are also massive gaps between the bulletpoints. Second level bulletpoints also aren't displaying: from

image

to

image

In other places, however, it's working mostly fine:

image

to

image

though still with the big gap

I think this may have come with v1.0, but I've put it separately from my other issue on that

hungsu commented 1 year ago

Hi @SerosKanjus , thanks for your interest in Typomagical!

I had a quick look and it appears that all of these concerns are to do with Obsidian 1.0, not Typomagical or any CSS theme. The HTML generated by Obsidian when I tried to reproduce your bug seems to be nonsense. In editor view as you noted Obsidian correctly registers the bullet as a list, with class HyperMD-list-line HyperMD-list-line-2. This should be converted to a new <li> in reader mode, but it is not - it's just text inside the existing <li>You'll notice that reverting to default theme, or any other theme, results in the same mess.

I'll be closing this issue as it's out of Typomagical's hands, but I strongly encourage you to file something with the official Obsidian board https://forum.obsidian.md/c/bug-reports/7