hungsu / typomagical-obsidian

An Obsidian theme for typographic appreciators, with support for Style Settings by mgmeyers
https://forum.obsidian.md/t/typomagical-a-theme-for-typographic-appreciators/26860
GNU General Public License v3.0
119 stars 6 forks source link

Multiple Elements of Styling Broken with V1.0 #53

Open SerosKanjus opened 2 years ago

SerosKanjus commented 2 years ago

Since the release of 1.0 (and its evidently significant rework of how themes function), multiple aspects of this theme's styling have broken/changed completely. I don't know if some of these are purposeful, but they all appeared upon updating obsidian, not the theme, so I'll assume they're not. I'm collecting what I've observed in one issue since there are many. Apologies if these should have gone as separate issues. For reference, I'm using the "ficus ruby" theme, in dark mode.


  1. Links: All links, internal and external, used to appear pink in small caps, suiting the theme image

    Internal links still do this, but contracted links appear blue now

    image

    and URLs are both blue and in a monospace sans serif

    image

  1. The "plain box" option for blockquotes used to appear as that: a pink box surrounding said quote all the way around (I have no image from the old version). It now is instead simply a white line to the left of the quote, not really distinguishing it from the surrounding text. image

    It would be nice if this could go back to matching the theme as before, as I'm not a fan of the other two blockquote stylings. There were some problems before with lines being part of the box or not in reader view, but it was still more distinctive.


  1. I'm not certain this came with v1.0, but in editor mode, a heading is in a heavy weight typeface and "attached" to the text underneath it: image

    in reader view, it's a lighter typeface and, more significantly, equidistant from the above text and that following:

    image

    This makes it a lot harder to see the structure of a note at a glance, which kind of makes reader view pointless.

In fact, reader view has a lot of seemingly brand new inconsistencies with the editor view, which has largely remained good: I'll try to write these up into a separate issues.

Apologies if any of these are in fact design choices: if so, I'll probably attempt to make my own fork.

hungsu commented 2 years ago

Hi @SerosKanjus , thanks for separating this from the other issue,

At a quick glance these are all bugs, not design choices, and thankfully not too hard to fix. I'll try to find some time in the next few days to look closer

SerosKanjus commented 2 years ago

Thanks: there are lots of little things like this, which I guess is to be expected with such a big overhaul.

Another one I discovered: the graph view's lines image

now look nothing like the lovely bright pink example that is featured on the store page:

image

Should I submit these things as separate issues as I find them? There are lots of little things, like the scroll bar colour, and I don't want to spam issue reports

hungsu commented 2 years ago

Hi @SerosKanjus ! In general I prefer separate issues, but can understand it can be a pain to make new issues since you have to think of a title every time. So for now let's consider this an Obsidian 1.0 Ficus Ruby bug thread, and if you find things distinct from Ficus Ruby those can go into another issue :)

SerosKanjus commented 2 years ago

I have no problem with thinking of titles for each individual issue, I just didn't want to flood the issues page with lots of minor posts!

hungsu commented 1 year ago

Hi @SerosKanjus , so sorry about the delays - I've been away in my home country seeing family and friends after many years :) I've fixed a couple of things:

Ficus ruby's Graph should have light pink lines by default, and the darker pink on hover Ficus ruby's external links should be the same colour as other links

SerosKanjus commented 1 year ago

No worries about the delay – I hoped you enjoyed your holiday!

Thanks for the fixes. This continues to be the nicest theme colour and typeface wise!