Closed joethei closed 6 months ago
Are there plans to address this, @hungsu? The latest Obsidian update seems to have broken the fonts in this theme by disallowing loading them, and the deadline stated in the issue is approaching.
Thanks for the reminder @omarkmu . There's a lot of work here so I'll be chipping away at this in pieces, hopefully all before deadline
A note to anyone following along: I most likely will be removing some fonts:
This is because I never use these, and the theme is already becoming quite large with the fonts I do use at 442KB. If anyone objects to this, feel free to file an issue and I can put them back.
Hi @joethei , can I confirm that I only need to remove network assets from theme.css
, or do I also need to remove them from the legacy obsidian.css
also?
Please do it for both.
@joethei All network requests should be removed. Instead of removing network requests from obsidian.css
, I have chosen to delete it as I do not believe anyone is using Obsidian older than 1.0.0 at this point. If there are more concerns please re-open this issue
It appears that your theme uses network connections to load assets (e.g. fonts, icons, or images). This is prohibited by the official Obsidian developer policies because themes should function completely locally.
You can bundle an asset for local use by using data URLs. See this guide.
Please let us know if you have any questions. Any themes that use network connections will be removed from the official directory in the first week of January 2024.