search

hungtcs / mxgraph-type-definitions

mxgraph type definitions
https://www.npmjs.com/package/mxgraph-type-definitions
Apache License 2.0
20 stars 8 forks source link

fix(mxConstants): add missing FONT_STRIKETHROUGH #11

Closed tbouffard closed 4 years ago

tbouffard commented 4 years ago

Introduced in mxgraph 4.1.0 by https://github.com/jgraph/mxgraph2/commit/650c8e162bc468272b3ea8848fb142868a2b8371

hungtcs commented 4 years ago

Hi @tbouffard! Many variables in mxConstants.ts has the wrong type (like ENTITY_SEGMENT), it should be number type instead of 3, because sometimes need to change it (for instance folding.html#L35). I will change the type in next commit.

https://github.com/hungtcs/mxgraph-type-definitions/blob/e1edaf6d260de5fd3fa11f253272c0512332cc64/util/mxConstants.d.ts#L628

tbouffard commented 4 years ago

@hungtcs thanks for merging my PR, I didn't have time to review the whole mxConstants class, just detect this issue so I did it quickly through GitHub Web UI. The styling was crappy (I just copied/pasted the js code from the mxGraph repo and ajust it), sorry for the inconvenience