hungtcs / mxgraph-type-definitions

mxgraph type definitions
https://www.npmjs.com/package/mxgraph-type-definitions
Apache License 2.0
22 stars 8 forks source link

Fix typescript strict check errors #15

Closed tbouffard closed 4 years ago

tbouffard commented 4 years ago

Fix TypeScript compilation errors. To ensure no new compilation errors are introduced, setup a GitHub workflow that check this on Pull Request and master branch.

closes #14

tbouffard commented 4 years ago

@hungtcs the worklow is currently not triggered. Can you check if the repository settings allow running actions from 3rd party please? This should work as described in https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories

hungtcs commented 4 years ago

Hi @tbouffard, the pull request not trigger workflow may be because the repository currently does not have a workflow, it only exists in the pull request, I created a test worklow, it will be trigger in the next pull request if nothing went wrong

tbouffard commented 4 years ago

Hi @tbouffard, the pull request not trigger workflow may be because the repository currently does not have a workflow, it only exists in the pull request, I created a test worklow, it will be trigger in the next pull request if nothing went wrong

@hungtcs you were totally right, I gave it a try by merging master into this PR branch, and the blank workflow and the newly introduce worklflow have been run.

tbouffard commented 4 years ago

@hungtcs I have pushed all commits related to the contribution I wanted to do. Feel free to review it. Thanks again for helping me with the GitHub Workflow so quickly, it was great (as always) :smile_cat:

hungtcs commented 4 years ago

Thank you, @tbouffard