Open hunkim opened 7 years ago
I'm willing to contribute about it :)
Do you think any web framework or language for web service?
And I wonder whether this service is only for Korean. (except Japanese, Chinese and others?)
I think it can also support Japanese and Chinese right now! (but I don't know about other languages)
I really appreciate your commitment! Perhaps, could you check if I miss something in the todo items?
Surely, it should support any languages.
For web service, I'm thinking of AngularjS2 + Firebase + github host. For wekbook service, we may use AWS lambda + S3 using PyGithub.
I'm new to both, but it's always fun to learn something new. Any thoughts?
@hunkim Hm, ah, Why do you separate the service to two services?
I think this service like this:
We provide a web service (translation_coverage) like travis. And, in web service, we also use the webhook internally.
User > Login > Register Repository in our web service > We are waiting the webhooks from github > Run the translation_coverage
when webhook is received
I agree. However, we need to develop two different services (web for human, and webhook for the github interactions)?
Could you explain the whole service architecture to me? (At technically point)
When does start it?
Should we simply implement it as a web-hook? When there is PR/PUSH, we clone and tun this and push back the results.
What do you think?
Yes, we should implement the web-hook first. And will make web service using the hooking service later. (after web-hook is done)
Additionally, I can develop the web service (I am web developer (almost backend))
Will we make the hooking/web service in here? (This repository)
Yes.
On Thu, Nov 3, 2016 at 4:41 PM, ming notifications@github.com wrote:
Will we make the hooking/web service in here? (This repository)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hunkim/translation_coverage/issues/11#issuecomment-258087586, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3DV2iv8E8oW6XVL26PXVWCvGRPc_67ks5q6Z4zgaJpZM4KTtA9 .
Could you build a structure of web-hook service here?
I think we can use the heruku + flask something like this, https://github.com/DeepLearningProjects/poem-bot?
I'm ok. I also know flask too. So, we should build a flask + heroku environments and make current translation coverage program to a single module for reusability. right?
How about it? (Very simple version)
/root /web (flask based) /hook (web-hook related) /coverage (as core util)
+1 On Thu, 3 Nov 2016 at 5:23 PM, ming notifications@github.com wrote:
How about it? (Very simple version)
/root /web (flask based) /hook (web-hook related) /coverage (as core util)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hunkim/translation_coverage/issues/11#issuecomment-258094758, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3DV5CH5ZvvN-6SzsEVXGkkhBRnJvL5ks5q6agYgaJpZM4KTtA9 .
Um, ok.
How can we work about that? Any ideas?
Perhaps, we need something like this:
Web service
Webhook service