Fix paint bucket - currently only working with a drag event

hunkim98 / dotting

Dotting is a pixel art editor component library for react

https://hunkim98.github.io/dotting/

MIT License

43 stars 12 forks source link

Fix paint bucket - currently only working with a drag event #110

Closed dooart closed 7 months ago

dooart commented 7 months ago

🚀 [Resolves #109 ]

Preview

N/A

Changes

Fix paint bucket - currently only working with a drag event

[🎨Component] Write a summary of what you have done on hooks

Right now the paint bucket only works if you drag the cursor after clicking. Just clicking won't work. This commit fixes the problem by adding a missing check in the mouse down handler.

Notes

N/A

Next Up?

N/A

hunkim98 commented 7 months ago

Thank you @dooart for the PR! I did not notice this problem! It seems that my current repository does not allow github actions for voluntary contributors! I will try to fix this issue first and then update the library with your feature update! Thank you once again! 🫡 If there are any questions regarding the library or any feature requests feel free to leave any questions on the issues tab or personal email!

dooart commented 6 months ago

no worries @hunkim98 - thank you for the great lib!