search

hunkim98 / dotting

Dotting is a pixel art editor component library for react
https://hunkim98.github.io/dotting/
MIT License
43 stars 12 forks source link

Removal of initBrushColor prop #18

Closed hunkim98 closed 1 year ago

hunkim98 commented 1 year ago

Currently the user can set brush color with useBrush hook.

However, since setBrushColor in Canvas.tsx can be called after the canvas element is mounted, I have added an initBrushColor prop to handle initially passed brush colors.

The problem is that this adds confusion to users. Maybe we could integrate setting brush color and initBrushColor prop into one?

This issue is closely related to issue #17

hunkim98 commented 1 year ago

Closing this issue since it was applied to ver 1.1.1