Feature: Better drawing method

hunkim98 / dotting

Dotting is a pixel art editor component library for react

https://hunkim98.github.io/dotting/

MIT License

43 stars 12 forks source link

Feature: Better drawing method #38

Closed Lee-Si-Yoon closed 1 year ago

Lee-Si-Yoon commented 1 year ago

🚀 [Related Issue: #36 ]

Preview

chrome-capture-2023-4-24 (2)

Write a title of your change

[🎨Component] Applied bresenham algorithm to drawing method (kudos to hunkim98)
[🔗Other] Added drawLine to math.ts

hunkim98 commented 1 year ago

https://github.com/hunkim98/dotting/assets/57612141/c1daa91e-5775-40f1-a31b-15a375493240

It seems that bressenham's algorithm does not apply when the mouse goes out of the pixel grid. I believe this is due to the pixel index being null when mouse move is out of pixel grid. Could you fix that if possible? 🚀

Lee-Si-Yoon commented 1 year ago

It seems that bressenham's algorithm does not apply when the mouse goes out of the pixel grid. I believe this is due to the pixel index being null when mouse move is out of pixel grid. Could you fix that if possible? 🚀

I cannot reproduce this bug, for now I've added a conditional to break if pixel index is null or undefined could you check if that problem is fixed?