Feature/improve extend - Githubissues

hunkim98 commented 1 year ago

🚀 [Related Issue: #4 ]

Preview

You can test the new extension algorithm in the PR preview page. Try to make the pixel grid very big and then test out the extension. The extension will not lag at all.

Changes

Improve extension algorithm to let the extension instantly happen

[🎨Component] Replace extendInteractionGrid, shortenInteractionGrid to extendInteractionGridBy and shortenInteractionGridBy
- Previously, when the pixel canvas was big, the extension lagged a little since the interaction grid extension happened one at a time. Unless a user moves the mouse, the extension did not occur
- To fix the above problem, I made functions that causes extensions to happen in chunks (extendInteractionGridBy & shortenInteractionGridBy). Now the extension happens instantly.
- Also, I have changed the extension to happen based on the mouseOffset(difference between the mouseDownWorldPos and mouseMoveWorldPos) instead of using lastMousePos.

Notes

Next Up?

github-actions[bot] commented 1 year ago

PR Preview Action v1.4.4 :---: Preview removed because the pull request was closed. 2023-06-03 00:34 UTC

hunkim98 commented 1 year ago

Great job LGTM except for one question(though it is out of scope)

when extending + zooming the drawn pixels are not aligned with pan zoom' scale will this have to be fixed?

It seems that this problem is due to the data layer not rendering when extension happens. I have disabled the rendering of data layer when extension happens since there would be unnecessary renders when extension occurs. When extension happens, the data does not change, so we do not need to render the data layer.

You can check that logic in

https://github.com/hunkim98/dotting/blob/be330b6de919489c7e7b90aa893224784fcfedea/src/components/Canvas/Editor.tsx#L1842-L1865

If there is capturedData, it means that the current user is extending the grids. If that is the case, all layers except the data layer are rendered.

I will fix this by disabling pan zoom when extension happens. I believe it is rare for a user to extend the pixel grid while also zooming.