Fix: paint bucket - Githubissues

hunkim98 / dotting

Dotting is a pixel art editor component library for react

https://hunkim98.github.io/dotting/

MIT License

43 stars 12 forks source link

Fix: paint bucket #61

Closed lerrybe closed 1 year ago

lerrybe commented 1 year ago

🚀 [Related Issue: #60 ]

Preview

https://github.com/hunkim98/dotting/assets/71599639/1e05839e-43e9-4c3d-a6bd-7137ee4aabe6

Changes

Write a title of your change

[🔗Other] Write a summary of what other things you have done
- Rename a function (-> colorPixelsArea)
- Remove interactionLayer.resetCapturedData();

Notes

I found that the data selected in interactionLayar was being initialized before the function ended.
I thought it's okay to remove it, so I deleted it.
But is there any dependence on other parts that I didn't catch or understand? If you have, please leave comment.
"undo" and "redo" work well now.

github-actions[bot] commented 1 year ago

PR Preview Action v1.4.4 :---: Preview removed because the pull request was closed. 2023-08-25 07:21 UTC

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication