Fix delta issues for select tool and clear action - Githubissues

hunkim98 / dotting

Dotting is a pixel art editor component library for react

https://hunkim98.github.io/dotting/

MIT License

43 stars 12 forks source link

Fix delta issues for select tool and clear action #71

Closed hunkim98 closed 1 year ago

hunkim98 commented 1 year ago

🚀 [Related Issue: #70]

Preview

Changes

Allow select tool to emit delta in `DataChangeHandler`

[🎨Component] Add logic for emitting delta in DataChangeHandler
- Previously, there was not delta emitted from select tool actions (extending, moving)
- Now, the modified pixels delta is emitted in the DataChangeHandler
[📒Docs] Add tools in the DataChangeHandler storybook component
- To allow testing of delta with other tools, I have added a <select> for choosing the desired tool

Allow `clear()` to emit delta information in `DataChangeHandler`

[🎨Component] Add logic in clear callback to emit delta data
- The clear callback did not emit any delta information
- Since clear erases all data in all layers, I emitted the data change event for every layer, allowing users to notice that all layers are being cleared

Notes

Next Up?

github-actions[bot] commented 1 year ago

PR Preview Action v1.4.4 :---: Preview removed because the pull request was closed. 2023-09-27 07:59 UTC

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
15.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint