huntabyte / bits-ui

The headless components for Svelte.
https://bits-ui.com
MIT License
1.09k stars 80 forks source link

Tabs work incorrectly in Svelte5 #458

Closed terion-name closed 4 months ago

terion-name commented 4 months ago

Describe the bug

Svelte5 is not released yet, but it's in pre-release and quite stable already, so it seems that it's okay to start adopting it =)

Tabs work weird in it. They render ok, they switch first time, but when you return to previos tab — later does not remove, so we stick with all tabs opened

Reproduction

https://stackblitz.com/edit/vitejs-vite-jkqgad?file=src%2FApp.svelte

Logs

No response

System Info

System:
    OS: Linux 6.6 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (10) arm64 undefined
    Memory: 577.29 MB / 9.71 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    bun: 1.1.3 - /tmp/bun-node-2615dc742/bun
  npmPackages:
    @sveltejs/kit: 2.5.5 => 2.5.5 
    bits-ui: ^0.21.3 => 0.21.3 
    svelte: 5.0.0-next.102 => 5.0.0-next.102

Severity

blocking an upgrade

huntabyte commented 4 months ago

We aren't supporting Svelte 5 until its stable, thanks!

terion-name commented 3 months ago

We aren't supporting Svelte 5 until its stable, thanks!

@huntabyte https://svelte.dev/blog/svelte-5-release-candidate

Svelte 5 is now in the Release Candidate phase. This means that the design of the framework is largely settled, with no anticipated breaking changes between now and the stable release, and that the most egregious bugs have been stomped.

Maybe it's time?)

shyakadavis commented 3 months ago

Hello, @terion-name

Work is already underway here: https://github.com/huntabyte/bits-ui/pull/469

In due time, we'll get a lovely release. Let's patiently wait. 🙂