search

huntabyte / bits-ui

The headless components for Svelte.
https://bits-ui.com
MIT License
1.19k stars 86 forks source link

chore: make v5 compatibility more flexible #555

Closed o-az closed 4 months ago

o-az commented 4 months ago

since svelte v5 is backwards compatible, updating peerDep range to <=5 means we don't have to update this when there's a new rc version.

This will make it similar to how melt-ui is currently: https://github.com/melt-ui/melt-ui/blob/develop/package.json#L61

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 5789cd48684c1502d92652b34ddc8b49365596aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 4 months ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview 5789cd48684c1502d92652b34ddc8b49365596aa
AdrianGonz97 commented 4 months ago

Can you provide a demo of this not working already? From my testing, if we don't include the -next.X flag, we'll break installs for npm users.

In fact, the way melt is doing it now breaks peer deps for users that use npm as their package manager: img

huntabyte commented 4 months ago

Closing as @AdrianGonz97 is correct here :)