search

huntabyte / cmdk-sv

cmdk, but for Svelte ✨
https://cmdk-sv.com
MIT License
423 stars 18 forks source link

fix: Move `Command` additional props to be declared directly in `CommandProps` type #31

Closed Not-Jayden closed 8 months ago

Not-Jayden commented 8 months ago

For whatever reason, the additional props declared on $$Props inside the Command.svelte component aren't included in the compiled output. Adding it directly to CommandProps resolves this problem.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: e5d1ccef46b6767dba5dd7bbd0a1d9e6dda0902a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | cmdk-sv | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-sv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2023 11:00am
Not-Jayden commented 8 months ago

As an aside, would you prefer I generate changesets if I happen to make any future PR's or is that being too presumptive?