Open niemyjski opened 3 months ago
To answer your points:
Space
to select items is not acceptable behavior for a Combobox. Space is a valid character that could be typed to further filter. Only Enter
selects the items.
<Command.Item id={option.value} value={option.value} onSelect={() => onValueSelected(option.value)}>
<div
class={cn(
'mr-2 flex h-4 w-4 items-center justify-center rounded-sm border border-primary',
$updatedValues.includes(option.value) ? 'bg-primary text-primary-foreground' : 'opacity-50 [&_svg]:invisible'
)}
>
<IconCheck className={cn('h-4 w-4')} />
</div>
<span>
{option.label}
</span>
</Command.Item>
If you can link a minimal repro I'm happy to take a look as well to see what's causing the issue. It may be an ordering issue of the components or something!
Yes, I'll work on a sample. We've just had massive power outages the past 2 days.
@huntabyte thanks for your patience, I've created a sample here. Just run npm install
and npm run dev
https://github.com/exceptionless/exceptionless-svelte-shadcn-cmdk-sv-repo
On a side note what is the best way to be more productive for team/community to reproduce issues and hopefully bring these into the test suite? Should we fork the project and create a pr with maybe story book or tests or would a template repo where everything is configured and we just fork be easier for you in the future?