search

huntabyte / cmdk-sv

cmdk, but for Svelte ✨
https://cmdk-sv.com
MIT License
410 stars 17 forks source link

Update versions #82

Open lfrancke opened 2 weeks ago

lfrancke commented 2 weeks ago

All of this is optional, feel free to close this PR.

Currently Github actions complains that outdated Node versions are used which will be deprecated/removed at some point. This means we need to update the Github actions versions and at the same time I took the liberty of pinning the dependencies. If you don't like that I can also move to the old v4 style again.

And when trying to run npm install with the current set of dependencies I get this error:

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: cmdk-sv@0.0.17
npm error Found: svelte@4.2.18
npm error node_modules/svelte
npm error   dev svelte@"^4.2.2" from the root project
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.35.0" from svelte-motion@0.11.5
npm error node_modules/svelte-motion
npm error   dev svelte-motion@"^0.11.4" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/lars/.npm/_logs/2024-06-18T08_56_58_646Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/lars/.npm/_logs/2024-06-18T08_56_58_646Z-debug-0.log

With the old mode-watcher dependency I get this ominous error:

npm error code EUNSUPPORTEDPROTOCOL
npm error Unsupported URL Type "link:": link:@testing-library/jest-dom/matchers
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 51dbb402d4aea7b2850cdcddc0896f50e875896a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | cmdk-sv | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-sv ❌ Failed (Inspect) Jun 18, 2024 8:58am
lfrancke commented 2 weeks ago

I can't see details on why Vercel failed. I did run npm run build and npm run test locally and it worked but there's a good possibility this broke something.