huntabyte / shadcn-svelte

shadcn/ui, but for Svelte. ✨
https://shadcn-svelte.com
MIT License
4.13k stars 259 forks source link

feat: initialize `scrollSnapsStore` on init #1055

Closed shyakadavis closed 1 month ago

shyakadavis commented 1 month ago

Follow-up for #1052

I'm really sorry for forgetting this; glad I was reminded of it when doing some Embal-related research here: https://github.com/davidjerleke/embla-carousel/discussions/847#discussioncomment-9260698

Speaking of, wanted to send a P.R for initializing the view slides as well, but that sounds too specific (like my use case), thus forewent that.

Thanks.

Before submitting the PR, please make sure you do the following

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 6b6b88c9495b91b03cbcc1edcc96c3233f11c0dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 6b6b88c9495b91b03cbcc1edcc96c3233f11c0dc
huntabyte commented 1 month ago

Is this already taken care of in the default style as well?

Edit: I just checked, and I'm not seeing it. Let's make sure it's added there as well so the two styles have feature parity.

Thank you!

shyakadavis commented 1 month ago

Oops. My bad, Hunter.

shyakadavis commented 1 month ago

Done, @huntabyte

Thanks. 🙂