search

huntabyte / shadcn-svelte

shadcn/ui, but for Svelte. ✨
https://shadcn-svelte.com
MIT License
4.95k stars 304 forks source link

isVisible is not an exported Prop of Pagination.Item #1077

Open Carlos-err406 opened 4 months ago

Carlos-err406 commented 4 months ago

Change Type

Correction

Proposed Changes

see here the usage section of the pagination docs

but the isVisible prop from Pagination.Item does not exist, since the props of this component are actually HTMLAttributes<HTMLLIElement>, see below for current implementation image

here a copy/paste from the docs showing the error image

my suggestion is to replace isVisible for hidden

Carlos-err406 commented 4 months ago

i could open a PR for this

huntabyte commented 4 months ago

Hey @Carlos-err406, let me investigate this a bit to see where the disconnect is here before opening a PR!

Carlos-err406 commented 4 months ago

sure!

jdgamble555 commented 1 month ago

I just came across this error. The examples are incorrect on the main site. Should this be there?