Open MentalGear opened 1 month ago
We could probably update these props to fallback to the hardcoded values if not provided as a prop?
Thanks for the reply, not sure though if we are aligned on the issue.
As a dev, if I only change the transition duration, I would expect the new value to be respected, e.g. 500 instead of 300 to slide the Sheet back.
Currently, this code will change the transition animation to a fade - which can't be correct.
<Sheet.Content side="left" outTransitionConfig={{ duration: 500 }}>
Describe the bug
I'm attempting to change the close / out transition duration of the
Sheet
component.However, using the suggested doc's component props approach:
results in the OUT animation changing to fade.
I also looked into the source code, and it seems like the values are hardcoded, if I correctly understand.
https://github.com/huntabyte/shadcn-svelte/blob/9cf14cc3f13569a84a754cbb61e80fe196ad4e3f/sites/docs/src/lib/registry/default/ui/sheet/index.ts#L55C14-L55C30
Reproduction
https://stackblitz.com/edit/github-9frs1r?file=src%2Froutes%2F%2Bpage.svelte
Logs
No response
System Info
Severity
blocking an upgrade