search

huntabyte / shadcn-svelte

shadcn/ui, but for Svelte. ✨
https://shadcn-svelte.com
MIT License
4.83k stars 302 forks source link

docs: Drawer causing issue with navigation #669

Open FortyGazelle700 opened 7 months ago

FortyGazelle700 commented 7 months ago

Describe the bug

When scroll down by some amount and open a drawer, fixed items like navigation disappear / fallback to very top of the page, instead of top of paint.

Reproduction

  1. Go to shadcn-svelte's Dialog Page or shadcn-svelte January 2024 Changelog
  2. Scroll down so that you can see the open drawer button, but just scroll down
  3. Click open drawer
  4. HERE; Navigation and other items break

Logs

N/A

System Info

Running Edge 119.0.2151.58 on Manjaro (Arch) Linux

Severity

annoyance

HubbeDev commented 7 months ago

@FortyGazelle700 From what I can see the same thing happens in the original shadcn-ui. And it's actually worse there where the header stays at the top of the dom after the drawer is opened. I think you should open the same issue there before it should be addressed here. What do you think @huntabyte?

FortyGazelle700 commented 7 months ago

From what I see Bekacru had found it out Dec 22, 2023 and made an Issue / Pull Request found here: fix(www): vaul drawer wrapper is causing the side bar to break its stickiness #2147

HubbeDev commented 7 months ago

@FortyGazelle700 Aha i se. thanks, I did not have the time right now to look for it. Think we should wait until it's merged.