huntabyte / shadcn-svelte

shadcn/ui, but for Svelte. ✨
https://next.shadcn-svelte.com
MIT License
5.48k stars 340 forks source link

Create a Combobox component with the bits ui primitive #917

Open TheOnlyTails opened 8 months ago

TheOnlyTails commented 8 months ago

Describe the feature

Bits UI has its own Combobox primitive now, so we shouldn't need to do a hack with the command and popover components

huntabyte commented 8 months ago

Until a similar component is in the original, it won't be added here. You are more than welcome to create a combobox using Bits' Combobox in your project if you wish.

huntabyte commented 7 months ago

Reopening to reconsider

ThatXliner commented 7 months ago

I would love it if we could use the bits ui combobox

jlforcherio99 commented 7 months ago

Performance for ~3000 rows is not great for the Combobox example provided on the ShadCn docs, but it seems a bit better using the BitsUI combobox. Definitely would be interested for our use case.

tzezar commented 7 months ago

Performance for ~3000 rows is not great for the Combobox example provided on the ShadCn docs, but it seems a bit better using the BitsUI combobox. Definitely would be interested for our use case.

For such large data sets, virtualization should be used anyway. I can't imagine rendering 3000 elements in one select on some older device. However, more performance is nice anyway! 💪🏻