search

huntabyte / vaul-svelte

An unstyled drawer component for Svelte.
https://vaul-svelte.com
MIT License
419 stars 17 forks source link

fix: programmatic opening #33

Closed mvcodelabs closed 7 months ago

mvcodelabs commented 7 months ago

When opening the drawer via bind:open a nasty bug prevents the animation from running.

This is a workaround made in a sleepless night

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: c5054353e4119d27c344f522ef40d220ab5baf6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vaul-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 2:56pm
huntabyte commented 7 months ago

Hey there, it appears lint is failing, did you run pnpm format / pnpm lint ? I'd like to get this merged! I'd make the changes myself but you made the PR from your main branch which will give me errors when trying to push to it locally!

mvcodelabs commented 7 months ago

Sure, i’ll fix the lint this week

Mattia Vitturi MV CODELABS - Tech Consulting & Software Development

📬 @.*** 📱 +39 389 423 2197 🌍 www.mvcodelabs.it

Il giorno dom 28 gen 2024 alle 20:12 Hunter Johnston < @.***> ha scritto:

Hey there, it appears lint is failing, did you run pnpm format / pnpm lint ? I'd like to get this merged! I'd make the changes myself but you made the PR from your main branch which will give me errors when trying to push to it locally!

— Reply to this email directly, view it on GitHub https://github.com/huntabyte/vaul-svelte/pull/33#issuecomment-1913693972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY2ZWYC6QVCCO3CEEBHGVCLYQ2PK3AVCNFSM6AAAAABCDH2732VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY4TGOJXGI . You are receiving this because you authored the thread.Message ID: @.***>