search

huntergregal / mimipenguin

A tool to dump the login password from the current linux user
Other
3.81k stars 633 forks source link

Not working on Ubuntu 14.04 #19

Closed bourgouinadrien closed 7 years ago

bourgouinadrien commented 7 years ago

09:18 abourgouin@Atuin ~/dev/mimipenguin(master) $ cat /proc/version Linux version 4.4.0-72-generic (buildd@lcy01-24) (gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3) ) #93~14.04.1-Ubuntu SMP Fri Mar 31 15:05:15 UTC 2017

Here the result of running command : https://pastebin.com/9MG3Ur4L

huntergregal commented 7 years ago

Woah, first time I've seen quotes in the salt of the hash!

Nice find - I'll make a quick fix for this soon. Just need to escape the quotes in the salt before passing it into the hashing function. Thanks for bringing up this issue.

bourgouinadrien commented 7 years ago

For shell grammar verification, you can use shellcheck https://github.com/koalaman/shellcheck

huntergregal commented 7 years ago

@bourgouinadrien I'm going to check that out now. Thanks for the tip. Also try it again with a fresh pull, I just pushed a fix

bourgouinadrien commented 7 years ago

@huntergregal I'll try on Tuesday, hoping I'll remember to ;)

huntergregal commented 7 years ago

Shellcheck is awesome. I cleaned up a lot of small grammar in my code.

I'm going to close this issue as I am pretty confident the problem is fixed. If it still persists please do open another issue. thanks for helping make this project better!

bourgouinadrien commented 7 years ago

So, I forgot to test again before 5 minutes ago... Just to say it works fine now ;)