huntergregal / mimipenguin

A tool to dump the login password from the current linux user
Other
3.79k stars 631 forks source link

Issue 53 ๐Ÿ‘ท add a GitHub Action for shellcheck #54

Closed thomasmerz closed 7 months ago

thomasmerz commented 1 year ago

This PR adds a GitHub Action for shellcheck for any push in master branch or for every PR - but only when any *.sh file has been updated.

thomasmerz commented 1 year ago

I did a "local GH Action run" with act:

๐ŸฆŽ๐Ÿ–ฅ  โœ” ~/temp/PRs/fork-mimipenguin [issue_53|โœ”]
15:20 $ act
[Shellcheck Lint/Shellcheck Lint] ๐Ÿš€  Start image=ghcr.io/catthehacker/ubuntu:act-latest
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker pull image=ghcr.io/catthehacker/ubuntu:act-latest platform= username= forcePull=true
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker create image=ghcr.io/catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker run image=ghcr.io/catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[]
[Shellcheck Lint/Shellcheck Lint] โญ Run Main actions/checkout@v3
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker cp src=/home/thomas/temp/PRs/fork-mimipenguin/. dst=/home/thomas/temp/PRs/fork-mimipenguin
[Shellcheck Lint/Shellcheck Lint]   โœ…  Success - Main actions/checkout@v3
[Shellcheck Lint/Shellcheck Lint] โญ Run Main Download Shellcheck
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1] user= workdir=
| shellcheck-stable/LICENSE.txt
| shellcheck-stable/README.txt
| shellcheck-stable/shellcheck
[Shellcheck Lint/Shellcheck Lint]   โœ…  Success - Main Download Shellcheck
[Shellcheck Lint/Shellcheck Lint] โญ Run Main Check Shellcheck Version
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/2] user= workdir=
| ShellCheck - shell script analysis tool
| version: 0.9.0
| license: GNU General Public License, version 3
| website: https://www.shellcheck.net
[Shellcheck Lint/Shellcheck Lint]   โœ…  Success - Main Check Shellcheck Version
[Shellcheck Lint/Shellcheck Lint] โญ Run Main Run Shellcheck
[Shellcheck Lint/Shellcheck Lint]   ๐Ÿณ  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3] user= workdir=
| shellcheck'ing ./mimipenguin.sh
|
| In ./mimipenguin.sh line 124:
|         export RESULTS="$RESULTS[HIGH]$4            $line\n"
|                         ^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
|
|
| In ./mimipenguin.sh line 127:
|             export RESULTS="$RESULTS[LOW]$4         $line\n"
|                             ^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
|
| For more information:
|   https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...
| Shellcheck failed for one or more shellscript(s)
[Shellcheck Lint/Shellcheck Lint]   โŒ  Failure - Main Run Shellcheck
[Shellcheck Lint/Shellcheck Lint] exitcode '1': failure
[Shellcheck Lint/Shellcheck Lint] ๐Ÿ  Job failed
Error: Job 'Shellcheck Lint' failed
๐ŸฆŽ๐Ÿ–ฅ  โœ” ~/temp/PRs/fork-mimipenguin [issue_53|โœ”]
thomasmerz commented 8 months ago

@huntergregal, has you seen my PR and can review and merge it? Thank you ๐Ÿ˜—

SouthHalfCents commented 8 months ago

ๆ‚จๅ‘้€็š„้‚ฎไปถๆˆ‘ๅทฒ็ปๆ”ถๅˆฐ๏ผŒๆˆ‘ไผšๅฐฝๅฟซๆŸฅ็œ‹ๅนถๅ›žๅคย ใ€‚ //ๆ˜Žๅค•ไฝ•ๅค•0x00 @.***

huntergregal commented 7 months ago

I don't want any github actions.