Closed PKostya closed 7 years ago
Which branch are you running? Do you have any other cards in your transfer list?
Had the same issue on feature branch. Cleared transfer list and no issue. Think the variable name was different can replicate and check if it is useful.
EDIT: I actually got the issue after running OK for 20 minutes
Interesting. It feels like you had an item in your transfer list that didn't have a resourceId. It would be good to see the values that created the issue so I can test against it.
When I release I'll add some error checking around it so the whole app doesn't blow up though.
Some stack and console if useful. stack.txt
Im getting a similiar error but the error is relatated to the propriety player.price.buy on the watchlist. Is there a way to solve it?
@kledac, do you have auto update pricing turned off in the settings? There is a setting for it, but turning it off is not yet supported.
@hunterjm this error i have when in my transfer list are some players wich i add manual to transfer from ps4
@hunterjm Its all on default. I checked and update pricing is on. I debuged the object that the call to FUT is returning and I have noticed that the object is always the same.
I tried to remove a player from my watchlist and know Its a blank space and that player got undefined. I managed to clear the localstorage to try with a new player, no luck, same error.
player.price is undefined and for that reason can't access player.price.buy ...
Can I send any log to you that could help?
This is the object I've got from the Watchlist, It's always the same the player doesn't matter.
The player should be Firmino, but that's not him. I've noticed that the trade is always invalid also, from ItemData.
Object {tradeId: 8241540833, itemData: Object, tradeState: "closed", buyNowPrice: 10000, currentBid: 800…} bidState : "outbid" buyNowPrice : 10000 confidenceValue : 0 currentBid : 800 expires : -1 itemData : Object assetId : 208135 attributeList : Array[6] cardsubtypeid : 2 contract : 0 discardValue : 312 fitness : 99 formation : "f433" id : 109655578054 injuryGames : 0 injuryType : "none" itemState : "invalid" itemType : "player" lastSalePrice : 0 leagueId : 13 lifetimeStats : Array[0] loyaltyBonus : 1 morale : 50 nation : 18 owners : 0 pile : 0 playStyle : 250 preferredPosition : "CM" rareflag : 0 rating : 78 resourceId : -1878840057 statsList : Array[0] suspension : 0 teamid : 1795 timestamp : 1484140066 training : 0 untradeable : true __proto__ : Object offers : 0 sellerEstablished : 0 sellerId : 0 sellerName : "FIFA UT" startingBid : 350 tradeId : 8241540833 tradeIdStr : "8241540833" tradeOwner : false tradeState : "closed" watched : true __proto__ : Object
@kledac How do you know that's not him? Can you do a JSON.stringify
of that object so I can see what's in itemData
? I will definitely add more error checking around the bidding overview screen, as that is where most of these errors are occurring.
Hey guys, I just finished unit testing the bid reducer and found a couple bugs in it. I think it may have to do with what you are seeing. Checkout the latest version of feature/cleanUp
and let me know if you stop running into these problems.
@hunterjm Hey, after the pull I still have the same problem =/
Here you go the object.itemData
{"id":109655578054,"timestamp":1484187177,"formation":"f433","untradeable":true,"assetId":208135,"rating":78,"itemType":"player","resourceId":-1878840057,"owners":0,"discardValue":312,"itemState":"invalid","cardsubtypeid":2,"lastSalePrice":0,"morale":50,"fitness":99,"injuryType":"none","injuryGames":0,"preferredPosition":"CM","statsList":[],"lifetimeStats":[],"training":0,"contract":0,"suspension":0,"attributeList":[{"value":71,"index":0},{"value":71,"index":1},{"value":73,"index":2},{"value":74,"index":3},{"value":71,"index":4},{"value":79,"index":5}],"teamid":1795,"rareflag":0,"playStyle":250,"leagueId":13,"loyaltyBonus":1,"pile":0,"nation":18}"
The undefined player.price happens on line 83 of Transfers.js.
warning: item.bidState !== 'highest' && player.price != undefined && item.currentBid < player.price.buy && item.expires > -1,
That && player.price != undefined
I've put there just to stop the red screen of death :p
@hunterjm I've just noticed this error also ... maybe they are related:
bid.js?03b6:156 Error searching auctions Error: Fut api error: {"debug":"","string":"","code":"460","reason":"","request":{"url":"/ut/game/fifa17/transfermarket?type=player&start=0&num=16&definitionId=180819¯=undefined","options":{"headers":{"X-HTTP-Method-Override":"GET"},"url":"/ut/game/fifa17/transfermarket?type=player&start=0&num=16&definitionId=180819¯=undefined","method":"POST"}}} at next (<anonymous>) at emitTwo (events.js:106:13) at Request.emit (events.js:191:7) at emitOne (events.js:101:20) at Request.emit (events.js:188:7) From previous event: at Fut.Methods.search.filter [as search] (eval at <anonymous> (http://localhost:3000/dist/bundle.js:7545:2), <anonymous>:51:19) at eval (eval at <anonymous> (http://localhost:3000/dist/bundle.js:10221:2), <anonymous>:11:18) at dispatch (eval at <anonymous> (http://localhost:3000/dist/bundle.js:4119:2), <anonymous>:45:18)
Should be unrelated. The problem with the first one is a player in your watchlist that is not in your player list on the AB. The second one is an issue with the API.
I'm probably going to delay releasing publicly since EA has been on a ban spree lately until I can verify the login authentication is as undetectable as possible.
@hunterjm No problems. If you want I can help you with testing and reporting that back to you. I'm studying node, but I'm still learning a lot I don't have the skill to correct and modify things in a meaningful way.
Anyway just let me know and thank you for your awesome work :)
Still seeing this. Sorry if it is to do error already discussed, hopefully it is useful. This is was with latest checkin.
Can you show me what's in the console error? The source map isn't working in that display. The developer console should have a more helpful error message with line numbers not in bundle.js
And this one which is unrecoverable.
Can you click on the arrow dropdown of the bid/set/watchlist
action and drill down into the action
object and let me see what's there? Same with the bid/set/listed
action.
While you are at it, drill down into "next state" and find bid->watchlist
and show me what's there as well.
From these screenshots, it looks like you have something in your watchlist that doesn't have an itemData
object. Which is a little weird. Want to see if it's a problem with the reducer, or if EA is actually sending something without itemData
back.
Hopefully this helps logg.txt
Unfortunately I need to see what's inside the array in Object {type: "bid/set/watchlist", watchlist: Array[10]}
Are you able to right click the object and click "Store as global variable"? If so, you should see something in the console like temp1
show up. If you then type copy(temp1)
in the console, it will copy the entire value to your clipboard which you can paste here using the insert code tag on top of the comment (looks like "< >")
Sure, newlog.txt - code tags did not format it at all well.
Is that the array from bid/set/watchlist
? If so, that's totally wrong 😞
should be fixed in 4079094. Pull it down and try again. That was a silly bug 😆
Aha, running for over 15 mins now seamlessly. This issue is resolved for me - impressive app I should add, thank you.
Great. I'll close this ticket out. Feel free to create a new one if there are any other issues you run into, or features you would like to see.