search

hunterloftis / jackrabbit

Simple AMQP / RabbitMQ job queues for node based on amqplib
292 stars 65 forks source link

add props to nack #47

Closed matthewmueller closed 6 years ago

matthewmueller commented 8 years ago

This PR adds additional options to nack(), most notably { requeue: false }

hamin commented 8 years ago

@matthewmueller @haircuttedfreak any chance we can get this PR rolling, we're dealing w/ issue where nack seems to be requeue-ing messages

hamin commented 8 years ago

@hunterloftis I just tested the changes locally and they seem to be working, I think travis config is broken but all the tests are still passing

Akamaozu commented 7 years ago

Why would you need requeue option for nack?

I think it would make sense to ack and do nothing with it in that case ...

colophonemes commented 7 years ago

Is there any plan to merge this? As @hamin says, nack() currently just requeues

@Akamaozu: you can use nack({requeue: false}) to route unprocessable messages to a dead-letter exchange: https://www.rabbitmq.com/dlx.html

cilindrox commented 7 years ago

@colophonemes we ended up forking and releasing the feat under @pagerinc/jackrabbit: https://github.com/pagerinc/jackrabbit