search

hunterloftis / jackrabbit

Simple AMQP / RabbitMQ job queues for node based on amqplib
293 stars 65 forks source link

Calls to publish messages before "connected" event should raise error #49

Open joshdickson opened 8 years ago

joshdickson commented 8 years ago

Hoping I can get around to a PR for this, but in the mean time just marking this down.

Trying to publish when there is not an active connection should raise an error. Instead, the event is swallowed and the sender is none the wiser.

I would think you'd want to make this explicitly clear to the caller right away via raising the error.

rahpuser commented 8 years ago

Raising an error is one option, another good behavior would be holding the message till an active connection appears.

joshdickson commented 8 years ago

This project is apparently dead - so I don't think either option will be getting done.

rahpuser commented 8 years ago

roger, in that case a 'Discontinued project' header would be appreciated in the read me @hunterloftis