hunterloftis / pbr

a Physically Based Renderer (PBR) in Go
MIT License
1.15k stars 42 forks source link

sample falcon.png is entirely black #20

Closed omac777 closed 6 years ago

omac777 commented 6 years ago

After running: ./pbr fixtures/models/falcon.obj -lat 0.5 -lon 0.5 -complete 5

I opened falcon.png and it was entirely black.

Same results in both linux and windows 7 msys2 shell with go1.10rc1.

hunterloftis commented 6 years ago

Let's try a different angle and a specific distance, just to be sure. Here's what I'm doing:

~/code/src/github.com/hunterloftis/pbr (master) 🐹  go version
go version go1.9.3 darwin/amd64
~/code/src/github.com/hunterloftis/pbr (master) 🐠  ./pbr fixtures/models/falcon.obj -lat 0.3 -lon=-0.6 -dist 1200 -complete 1

falcon

I'll try with 1.10rc1 in just a minute.

hunterloftis commented 6 years ago

I get an identical result with this:

~/code/src/github.com/hunterloftis/pbr (master) 🐠  go1.10beta2 build ./cmd/pbr
~/code/src/github.com/hunterloftis/pbr (master) 🐍  go1.10beta2 version
go version go1.10beta2 darwin/amd64
~/code/src/github.com/hunterloftis/pbr (master) 🐯  ./pbr fixtures/models/falcon.obj -lat 0.3 -lon=-0.6 -dist 1200 -complete 1
19.5s, samples (0.5 mil, 23/ms), rays (1.5 mil, 3.2/sample) [ 1 s/px ===>      falcon.png ]
~/code/src/github.com/hunterloftis/pbr (master) 🐧  open falcon.png

Are we rendering the exact same file? What's the md5 of your falcon.obj?

~/code/src/github.com/hunterloftis/pbr (master) 🐺  md5 fixtures/models/falcon.obj
MD5 (fixtures/models/falcon.obj) = 7e86dfba03e61c169ceaf85b842e1175
hunterloftis commented 6 years ago

I think this was probably fixed by https://github.com/hunterloftis/pbr/pull/21 - fixtures weren't being downloaded properly.