hunterwilkins2 / bulldog-books

An online bookstore for UGA CSCI 4050. Created with React and Node.

MIT License

2 stars 3 forks source link

Figure out what a promotion is #41

Closed hunterwilkins2 closed 3 years ago

hunterwilkins2 commented 3 years ago

What the hell is a promotion?

Is it a sale on a particular book?
Is it a general 20% off all purchases?
What is the time span a promotion is active?

What we need to do

[ ] Update the promotions schema
[ ] Add the routes in issue #40

nssafir commented 3 years ago

https://piazza.com/class/kjnjczjdlmr38b

hunterwilkins2 commented 3 years ago

I think the way we should set it up is that the promotion is a flat discount on all books in the order. And then the promotion has a specific end date and optional start date or the date of creation. We can wait and see what she says on piazza or just go ahead and implement it and change anything if need be. They seem pretty lenient on stuff not explicitly stated in the rubric.

nssafir commented 3 years ago

I talked with someone else and I think you're right. I'm going to go ahead and implement it that way, can always change it later