search

hunzikp / velox

https://hunzikp.github.io/velox/
119 stars 23 forks source link

Added focal standard deviation filter #38

Open mwip opened 5 years ago

mwip commented 5 years ago

I missed a standard deviation filter. The raster::focal version is not usable at all for large data sets.

codecov-io commented 5 years ago

Codecov Report

Merging #38 into master will decrease coverage by 4.9%. The diff coverage is 1.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   50.02%   45.12%   -4.91%     
==========================================
  Files          21       23       +2     
  Lines        1765     1724      -41     
==========================================
- Hits          883      778     -105     
- Misses        882      946      +64
Impacted Files Coverage Δ
R/velox_focal.R 0% <0%> (ø) :arrow_up:
src/stddev.cpp 0% <0%> (ø)
src/integral.cpp 1.12% <1.12%> (ø)
src/focal.cpp 1.12% <4.76%> (-0.33%) :arrow_down:
R/velox_rasterize.R 73.91% <0%> (-3.14%) :arrow_down:
R/velox_cast.R 55.26% <0%> (-2.88%) :arrow_down:
R/velox_extract.R 51.7% <0%> (-1.84%) :arrow_down:
R/velox.R 85.1% <0%> (-1.43%) :arrow_down:
R/boostgeom.R 53.57% <0%> (-0.82%) :arrow_down:
R/velox_aggregate.R 0% <0%> (ø) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff7bc3c...afd8efe. Read the comment docs.

mwip commented 5 years ago

What does this even mean? I never changed the respective source files. Please let me know, if this poses any issues to the merge and how to solve it.