search

huonw / primal

primal puts raw power into prime numbers.
http://docs.rs/primal/
Apache License 2.0
108 stars 17 forks source link

Test primal on i686 #13

Closed cuviper closed 6 years ago

cuviper commented 6 years ago

Locally, I found that some tests were failing on i686, so it seems like a good idea to add this to CI.

There was an error in the upper bound of the nested Primes sieve, which was only seen on i686 just because the equivalent breaking point on x86_64 was much higher than people realistically use it for.

autohuonw commented 6 years ago

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

cuviper commented 6 years ago

i686 failures:

---- streaming::primes::benches::iterate_huge stdout ----
    thread 'streaming::primes::benches::iterate_huge' panicked at 'called `Option::unwrap()` on a `None` value', /checkout/src/libcore/option.rs:335:20

---- streaming::primes::tests::equality stdout ----
    thread 'streaming::primes::tests::equality' panicked at 'called `Option::unwrap()` on a `None` value', /checkout/src/libcore/option.rs:335:20

This is what I got locally too. I've bisected this to commit c7014598e08ac2982948eb4aade16aed316bfb0c, but I'm not yet sure what's wrong.