search

huonw / primal

primal puts raw power into prime numbers.
http://docs.rs/primal/
Apache License 2.0
108 stars 17 forks source link

bors: add appropriate configuration for it. #21

Closed huonw closed 5 years ago

huonw commented 5 years ago

Also, remove homu.

huonw commented 5 years ago

bors try

bors[bot] commented 5 years ago

try

Build succeeded

huonw commented 5 years ago

bors try

bors[bot] commented 5 years ago

try

Build succeeded

cuviper commented 5 years ago

bors r+

notriddle commented 5 years ago

@cuviper It didn't go through because "REVIEW REQUIRED: At least 2 approving reviews are required by reviewers with write access."

cuviper commented 5 years ago

@huonw Requiring 2 reviewers seems harsh when AFAIK you and I are the only ones with write access. Or do the checks (like bors) count as a review?

notriddle commented 5 years ago

The bors checks don't count as a review. It counts as a status check.

Also, you probably want to add required_approvals to the bors.toml, and turn this check off in GitHub, so that it gives you a real warning message instead of ragequitting with a 422 after it tries to push it to master.

huonw commented 5 years ago

Oh, that's unfortunate. I don't actually think we need 2 approvals: I was trying to find a way to disable the big green merge button, because otherwise I'll forget to use bors.

However, it seems bors sets a status check though, so I've switched to requiring that.

huonw commented 5 years ago

bors r=cuviper

bors[bot] commented 5 years ago

Build succeeded

huonw commented 5 years ago

That works! 🎉