search

huonw / travis-cargo

A standalone script that manages running Rust's cargo and several other related features on Travis CI.
https://pypi.python.org/pypi/travis-cargo
Apache License 2.0
174 stars 27 forks source link

Consider making nightly --features passing smarter #33

Open huonw opened 9 years ago

huonw commented 9 years ago

Currently travis-cargo will pass --features $TRAVIS_CARGO_NIGHTLY_FEATURE, or --features unstable if that env var doesn't exist. It might be nice to make this more intelligent by default, by parsing the toml file to look for a feature either unstable or nightly and pass that, falling back to passing nothing if neither exist (but still obeying the env var override).

jdub commented 9 years ago

In the meantime, for those who stumble on this, here's the workaround for .travis.yml as suggested by @huonw:

env:
  global:
    - TRAVIS_CARGO_NIGHTLY_FEATURE=""
huonw commented 9 years ago

I've seen "dev" used as the name of this feature in the wild too.

jdub commented 7 years ago

Interesting corner case on this one: You can't set an empty environment variable in Windows. Setting an environment variable to "" deletes it.

Yes, you now have a travis-cargo user on Windows / Appveyor. 😄

https://ci.appveyor.com/project/jdub/pathfinder/build/job/c54yd248q6qbeo8p

And this is not some quixotic quest! There is a working build for stable:

https://ci.appveyor.com/project/jdub/pathfinder/build/job/lvejvt96aflpd9xb