search

huonw / travis-cargo

A standalone script that manages running Rust's cargo and several other related features on Travis CI.
https://pypi.python.org/pypi/travis-cargo
Apache License 2.0
174 stars 27 forks source link

Remove now default 'sudo: false' #48

Closed frewsxcv closed 8 years ago

frewsxcv commented 8 years ago

sudo: false is now default on Travis CI

autohuonw commented 8 years ago

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

huonw commented 8 years ago

I'm lead to believe that it's been the default for quite a while, but I (and others) have had Travis behave somewhat inconsistently around sudo. I personally suspect (but haven't investigated in detail) that a repo where travis was activated before sudo: false became the default will actually have the old default, i.e. Travis is avoiding breaking them. I've explicitly kept this (AFAIK) harmless line to ensure the example configuration will give the best behaviour with all repos.

Maybe something has changed?

frewsxcv commented 8 years ago

Travis is avoiding breaking them

I haven't personally noticed this, but I don't have any evidence to prove one or the other here.

I've explicitly kept this (AFAIK) harmless line to ensure the example configuration will give the best behaviour with all repos.

Fair enough, carry on