search

hupe1980 / cdkdx

Zero-config CLI for aws cdk development
MIT License
38 stars 8 forks source link

fix: --no-npmignore is no longer an option for jsii-pacmak #31

Closed justinm closed 2 years ago

justinm commented 2 years ago

This PR attempts to address the issue as described in #30 by removing the --no-npmignore flag from the call to jsii-pacmak.

justinm commented 2 years ago

I was premature, this does not resolve the issue. It seems to be deeper inside of libnpmpack, specifically const destination = path.resolve(opts.packDestination, filename) on line 43 of lib/index.js. opts.packDestination is undefined. Adding a ?? "" fixes my issue locally.