hupe1980 / gatsby-plugin-material-ui

Gatsby plugin for Material-UI with built-in server-side rendering support
MIT License
136 stars 25 forks source link

Update to work with Gatsby 5 #110

Open choffa opened 1 year ago

choffa commented 1 year ago

Currently installing this plugin without using --legacy-peer-deps fails when using gatsby@>=5.0.0.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: gatsby-starter-default@0.1.0
npm ERR! Found: gatsby@5.1.0
npm ERR! node_modules/gatsby
npm ERR!   gatsby@"^5.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^3.0.0 || ^4.0.0" from gatsby-theme-material-ui@5.3.0
npm ERR! node_modules/gatsby-theme-material-ui
npm ERR!   gatsby-theme-material-ui@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/christopher/.npm/_logs/2022-11-22T19_48_06_169Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/christopher/.npm/_logs/2022-11-22T19_48_06_169Z-debug-0.log

I am not familiar enough with the plugin or gatsby to say if code needs to be updated or only the peer dependency definition...

deekshasharma commented 1 year ago

We are getting this warning when trying to install gatsby-plugin-material-ui with gatsby 5.0.0

Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.0.0 - It requires gatsby@^3.0.0 || ^4.0.0
yolomep commented 1 year ago

For now, the latest version of gatsby-plugin-material-ui seems to work with gatsby v5 for most components.

kdichev commented 1 year ago

seems like there is a PR implementing the changes already #111 by @blackspherefollower @hupe1980 can we get that in so we can update to latest Gatsby versions in our apps?

warn Plugin gatsby-theme-material-ui-top-layout is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui-top-layout is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-plugin-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
warn Plugin gatsby-theme-material-ui is not compatible with your gatsby version 5.3.3 - It requires gatsby@^3.0.0 || ^4.0.0
jcpinillos commented 1 year ago

Is there any update on when we could be expecting this plugin to work with Gatsby 5? Like kdichev was asking 3 weeks ago, there seems to be a fix in place.

blackspherefollower commented 1 year ago

FYI, I published my fork (just the Gatsby 5 change in the PR) as https://www.npmjs.com/package/@iostindex/gatsby-plugin-material-ui as a temporary solution

Marco-Daniel commented 1 year ago

Also ran into this issue today starting a new project. Any update on when it will work with Gatsby 5?

guicompeng commented 11 months ago

I also want to start a new project, any updates?

shalupova-a commented 10 months ago

would be nice to get a status update on this.

Console32 commented 10 months ago

@hupe1980 Any chance to get some maintainers on board for this? I would offer to engage.

kdichev commented 10 months ago

@hupe1980 Any chance to get some maintainers on board for this? I would offer to engage.

he is MIA I've tried contacting him on multiple platforms to either give access to other maintainers or give the repo to somebody else

blackspherefollower commented 10 months ago

FWIW: I'll keep my fork up-to-date for as long as I'm using it

guicompeng commented 8 months ago

MUI updated the example and it is possible to use Gatsby 5 and MUI without this plugin: https://github.com/mui/material-ui/tree/master/examples/material-ui-gatsby