search

hupe1980 / react-script-hook

React hook to dynamically load an external script and know when its loaded
MIT License
127 stars 21 forks source link

Value of `load` never changes #35

Open allroundexperts opened 2 years ago

allroundexperts commented 2 years ago

We're facing an issue where if the hook un-mounts before the onload handler being called, the value of load remains true indefinitely. This makes sense if you read through the code as well.

If the component un-mounts before the handler given here gets called: https://github.com/hupe1980/react-script-hook/blob/master/src/use-script.tsx#L111 then the load value will always remain true even on subsequent mounts because the script has been loaded and we removed the event listener for load before it could be fired. This is causing our E2E tests to break intermittently.

jonsadka commented 1 year ago

Also experiencing this same issue

PC98 commented 1 year ago

@allroundexperts or @jonsadka do you guys have some code where I can easily reproduce this issue?

It seems react-script-hook is largely an unmaintained library, I am open to migrating the code to use something else but will need to make sure we have a way to test it works.