search

hupili / snsapi

Cross platform middleware for Social Networking Services: Twitter, Facebook, SinaWeibo, Renren, RSS, Email, Sqlite, ... (more coming)
http://snsapi.ie.cuhk.edu.hk
159 stars 53 forks source link

Dev #111

Closed wcyz666 closed 10 years ago

wcyz666 commented 10 years ago

Instagram

wcyz666 commented 10 years ago

Where is the error?

hupili commented 10 years ago

The UT should pass. The RSS2RW's case test_rss2rw_update_message_timeout_append or test_rss2rw_update_message_timeout_simulate have race conditions. Those sometimes fail when it should not. You can find details of the error on Travis. If it is related with the two, you can try to re-run the test.

hupili commented 10 years ago

As to the "race condition" mentioned in previous comment, you do not have to deal with it. It is the inappropriate design of the test case itself. We can try to find better way to test it later.

wcyz666 commented 10 years ago

Is it OK now?

wcyz666 commented 10 years ago

I will try to upgrade rss testcase tomorrow

hupili commented 10 years ago

What is the snsapi/plugin_trial/emailstest.py file?

hupili commented 10 years ago

Also merge with the latest dev to keep up to date with baseline:

git pull git@github.com:hupili/snsapi.git dev
wcyz666 commented 10 years ago

I have merge the latest dev and there's no conflict.

hupili commented 10 years ago

How about the snsapi/plugin_trial/emailstest.py file?

wcyz666 commented 10 years ago

Er? What's wrong with that file? I did not modify it

hupili commented 10 years ago

You added that file according to the accumulated diff.

wcyz666 commented 10 years ago

What....? I knew nothing about it... It seems to be a copy of the original file. I have deleted it

wcyz666 commented 10 years ago

Sorry for those mistake. Thank you for your patience！