search

huppertt / nirs-toolbox

Toolbox for fNIRS analysis
86 stars 61 forks source link

Fix for changing stimulus duration using change_stimulus_duration and other changes #18

Closed AdrianCurtin closed 1 year ago

AdrianCurtin commented 1 year ago

This PR includes several fixes 1) uses new syntax to assign stimulus duration within the change_stimulus_duration function 2) Modifies loadBIDS error message when loading json to make it more informative and warn instead of crashing 3) Modify AddDemographics to not fail if var2match is completely missing, but missing is allowed (as in case for missing UUID in demographics table) 4) Change behavior of +nirs/+util/snirf2data.m to a) transpose source/detector/landmark coordinates if not presented directly b) express preference for Pos as best, then xxxPos3D field as next best, then Pos2D in that order c) Rename sd labels to 'Source-#'/ 'Detector-#' if number is provided. Otherwise autogenerated labels are used d) consolidated behaviors for source, detector, and landmarks so that all position types are treated in the same manner for rotation etc

AdrianCurtin commented 1 year ago

@hendriksantosa , requesting review here