Fix keyToggle does not release key

hurdlegroup / robotjs

Node.js Desktop Automation.

http://robotjs.io

MIT License

47 stars 5 forks source link

Fix keyToggle does not release key #17

Closed rivafarabi closed 4 months ago

rivafarabi commented 5 months ago

After certain key is toggled by keyToggle('w', 'down') , the key keeps getting pressed even after the keyToggle('w', 'up') gets called. The issue mainly occurred in some software, mainly games.

Based on comments on https://github.com/octalmage/robotjs/issues/252 and https://github.com/nut-tree/libnut-core/pull/87, removing the scan code for keyup event solve this certain issue.

The softwares (games) that have been tested:

Monster Hunter World
Monster Hunter Rise
The Witcher 3

DanielMcAssey commented 4 months ago

Thanks for this!

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 0.11.6 :tada:

The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: