search

huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections
http://www.uwazi.io
MIT License
242 stars 80 forks source link

Geolocation property import fails due to user error but no error message given #4959

Open llfinch opened 2 years ago

llfinch commented 2 years ago

Describe the bug I was trying to import entities with a geolocation property into my personal instance. It's very simple: just a title and the "geolocation" property. I failed to stylize the column header as "geolocation_geolocation" as our quirky import requires.

test import.csv

When I imported, the system told me "Import completed: 6 created. Indexing entities may take a few minutes", seemingly accepting what I had created in the CSV. However, when I went to examine the imported entities, none of them had the geolocation data; the property appeared as empty.

When I amended the CSV to have the proper column header (thanks to @natasha-todi flagging this for me after asking for help internally so I could correct my attempts), the geolocation data was correctly imported. But there was no difference in the user experience - each time, the system acted like I had done everything right, which made it hard to realize what I was doing wrong.

To Reproduce Steps to reproduce the behavior:

  1. Create a simple "State" entity template that has a text-based Title property and a "Geolocation" property
  2. Try to import the CSV I referenced earlier and see how the system seemingly accepts it without error message
  3. Check the entities and see that they don't have the geolocation property data
  4. Correct the column header to be "geolocation_geolocation" and see how the user experience is the same, but this time it actually imported correctly

Expected behavior If I've styled my CSV incorrectly, I would expect the system to throw an error message at me to flag that something hadn't been imported correctly, so that I could then correct my CSV.

Screenshot What appears even though there was an error in how I had configured my CSV: image

RafaPolit commented 2 years ago

We should really remove this requirement of adding the _geolocation and try to handle this exception to the property naming convention internally. Forcing the user to "remember" to add the _geolocation is a recipe for disaster.

llfinch commented 2 years ago

10,000% agree, @RafaPolit!

Although I think it's also an important issue to address that Uwazi indicates for the user in some way when it doesn't recognize a column for whatever reason, beyond this specific geolocation column header issue. Because otherwise it's not ideal for a user to be under the impression that everything went well, only to later look through their entities and discover something isn't right.