search

huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections
http://www.uwazi.io
MIT License
242 stars 80 forks source link

Bump react and @types/react #6752

Closed dependabot[bot] closed 6 months ago

dependabot[bot] commented 6 months ago

Bumps react and @types/react. These dependencies needed to be updated together. Updates react from 18.2.0 to 18.3.1

Release notes

Sourced from react's releases.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874
Changelog

Sourced from react's changelog.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874
Commits
Maintainer changes

This version was pushed to npm by react-bot, a new releaser for react since your current version.


Updates @types/react from 18.0.25 to 18.3.1

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mfacar commented 6 months ago

This PR has a resolution conflict of versions for @types/react and @types/react-dom from different dependencies that have previous versions of these packages. This option is proposed to handle the inconvenience. There weren't problems after the fix and all the workflows were succeded.

Any thoughts about this? @RafaPolit, @konzz, @Zasa-san

Zasa-san commented 6 months ago

This PR has a resolution conflict of versions for @types/react and @types/react-dom from different dependencies that have previous versions of these packages. This option is proposed to handle the inconvenience. There weren't problems after the fix and all the workflows were succeded.

Any thoughts about this? @RafaPolit, @konzz, @Zasa-san

It seems to be the correct solution, given the discussion you linked. One thing I don't follow is the apparent downgrade of "react-dom", it looks like we are going from 18.2.0 or above to 18.1.1 or above.

It would also be good to run the app once and check for warnings, since the changelog says This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. Just to double check.

mfacar commented 6 months ago

Thank you @Zasa-san, I checked the warnings on the console and didn't notice any new warnings but the same regarding the lifecycle that we already have. But actually. I introduced an error of type props that I could detect thanks to your suggestion 🙌 The downgrade of the version of "react-dom", it is an error while I was trying different options, thank you for pointing to that.

mfacar commented 6 months ago

Update: After closing I noticed some new warnings on the server console, as @Zasa-san pointed out, related to the deprecation of the support for default values in functional components props in react v19, these are present in some components like Icon and MatomoConfig. Although a little annoying, there are not functional impacts on the application.