huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections
http://www.uwazi.io
MIT License
242 stars 80 forks source link

Uwazi allows users to create thesauri with the same labels #6853

Closed serena-huridocs closed 5 months ago

serena-huridocs commented 5 months ago

Describe the bug A user can add thesauri with the same labels while doing it in the template creation menu.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Template'
  2. Click add Thesauri
  3. When adding new Thesauri by clicking the button on the bottom panel, a user can add thesauri with the same names. The thesauri with the same names are not displayed on the Thesauri list on the Select property.
  4. Navigate to the Thesauri and find Thesauri with the same names.

Screenshot 2024-06-03 at 15 08 08

In the screenshot, you can see three Thesauri with the same names: Şehir.

Expected behavior Uwazi does not allow users to create the Thesauri with the same names.

Device (please select all that apply)

Additional context A user was having some issues with the internet connection while adding thesauri.

RafaPolit commented 5 months ago

We cannot reproduce this. The only way this happens is if you accidentally append spaces after the name. Can you please confirm? Thanks.

serena-huridocs commented 5 months ago

I confirm. The thesauri were created by a user from the partner's team, and I made the conclusion based on what was displayed on the screen. My apologies, I am closing the issue. However, from a UX perspective, it may be worth disabling the creation of thesauri which practically have the same names except for an additional space symbol put after the name.

txau commented 5 months ago

we definitely have several places in which trimming spaces would have prevented problems. I'll open an issue about it.

serena-huridocs commented 5 months ago

we definitely have several places in which trimming spaces would have prevented problems. I'll open an issue about it.

thank you a lot @txau 🙏