Files health check should not account for url attachments

huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections

http://www.uwazi.io

MIT License

236 stars 79 forks source link

Files health check should not account for url attachments #6992

Closed fnocetti closed 2 months ago

fnocetti commented 2 months ago

The files health check script is counting attachments that are not stored files but urls as missing in storage, while they are by definition not put in the storage.

aphilop commented 2 months ago

@txau @RafaPolit What is the importance/severity of this in order to judge about its priority?

txau commented 2 months ago

I think this should by an easy fix. @fnocetti and @varovaro have a better knowledge of the insides, but my take is that a quick check with a regexp to tell the URLs from the files apart would fix this so the results of the health check are more accurate.

If that is so, I would put it as high in order to:

have a proper health check
wrap up this whole functionality now that we are at it

fnocetti commented 2 months ago

This is definitively an easy fix. I will leave a PR ready before today EOD

daneryl commented 2 months ago

I have reviewed and tested @fnocetti PR LGTM, merged and deployed.